Fix package.json search for JavaScript #2040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudolf101
added
lang-javascript
Markoutte
approved these changes
Mar 27, 2023
| val matchingFiles: Array<File> = currDir.listFiles( | ||
| FilenameFilter { _, name -> | ||
| return@FilenameFilter name == "package.json" | ||
| } | ||
| ) ?: throw IllegalStateException("Error occurred while scanning file system") | ||
| if (matchingFiles.isNotEmpty()) return parseConfig(matchingFiles.first()) | ||
| currDir = currDir.parentFile | ||
| } while (currDir.path != projectPath) | ||
| } while (currDir.path.replace("\\", "/") != projectPath) |
There was a problem hiding this comment.
Better way to handle this problem is to put projectPath into File object and compare files instead of strings. Try this:
File file = new File("C:/Windows/Resources");
File f = new File("C:\\Windows\\Resources");
System.out.println(Objects.equals(file, f));Or with newer API (Also, I show prev example with normalization only for example):
Path file = Paths.get("C:/Windows/Resources/Themes/..").normalize();
Path f = Paths.get("C:\\Windows\\Resources").normalize();
System.out.println(Objects.equals(file, f));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the plugin has been reinstalled with IDEA restart and project clean & experimental languages support enabled, the action called for the JS file works properly.
Fixes #1947
How to test
Manual tests
Follow this steps:
Self-check list